Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for Cypress Cloud #684

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Initial support for Cypress Cloud #684

merged 1 commit into from
Nov 23, 2023

Conversation

kasperg
Copy link
Contributor

@kasperg kasperg commented Nov 16, 2023 •
edited
Loading

Description

This should allow running tests in parallel to provide a faster testing process. Also it may provide a better test debugging experience.

All setup is based on the example from the documentation: https://github.com/cypress-io/github-action#split-install-and-tests.

Additional comments or questions

My own observations:

  • Parallelization brings down integration test time from 10 mins in Esbuild loader #683 , 9 mins in Added ability to cancel pause period #681 and 25 mins(!) in Refactor reservation pause banner #680 to ~5 mins (x3). Of this 5 minutes ~2 minutes are spent setting up containers, Node and running yarn install.
  • I find the PR comment annoying. It is just noise.
  • We currently run tests on both pushes and pull requests. Perhaps we could reduce this.
  • If we want to go with this we need to update required GitHub Actions
  • For the moment I do not think Cypress Cloud provides something unique that we do not already have (logs, screenshots, videos etc.) but the UI they provide is a nice way to access this.

@kasperg
Initial support for Cypress Cloud
24d5bb8 
This should allow running tests in parallel to provide a faster testing
process. Also it may provide a better test debugging experience.

All setup is based on the example from the documentation:
https://github.com/cypress-io/github-action#split-install-and-tests
@cypress Cypress
Copy link

cypress bot commented Nov 16, 2023

Passing run #15 ↗︎

0 122 7 0 Flakiness 0

Details:

Initial support for Cypress Cloud
Project: React components Commit: 24d5bb82c0
Status: Passed Duration: 03:37 💡
Started: Nov 16, 2023 2:38 PM Ended: Nov 16, 2023 2:42 PM

Review all test suite changes for PR #684 ↗︎

@cypress Cypress
Copy link

cypress bot commented Nov 16, 2023

Passing run #16 ↗︎

0 122 7 0 Flakiness 0

Details:

Merge 24d5bb8 into aa29c1d...
Project: React components Commit: 0c2c7c6bd6 ℹ️
Status: Passed Duration: 03:59 💡
Started: Nov 16, 2023 2:38 PM Ended: Nov 16, 2023 2:42 PM

Review all test suite changes for PR #684 ↗︎

@Adamik10 Adamik10 changed the base branch from develop to demo_2023-48-0 November 20, 2023 11:15
@spaceo spaceo self-requested a review November 20, 2023 12:18
spaceo
spaceo approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@spaceo spaceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@spaceo spaceo removed their assignment Nov 20, 2023
@kasperg kasperg merged commit 870e7f3 into demo_2023-48-0 Nov 23, 2023
20 checks passed
@kasperg kasperg deleted the cypress-cloud branch November 23, 2023 19:37
@kasperg kasperg restored the cypress-cloud branch December 28, 2023 06:58
@kasperg kasperg mentioned this pull request Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaceo spaceo spaceo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperg @spaceo